Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing endpoints and fixed delete endpoints /w auth #4

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

jay-dee7
Copy link
Member

Signed-off-by: jay-dee7 jasdeepsingh.uppal@gmail.com

  • Get Manifest endpoint was deleted accidentally, so this PR adds it back
  • We now close req bodies immediately after reading them
  • Added Delete (Image, Layer) endpoints, but they don't delete anything yet (since deleting is kind of tricky on SkyNet)

Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
@jay-dee7 jay-dee7 requested a review from guacamole July 10, 2021 12:52
@jay-dee7 jay-dee7 self-assigned this Jul 10, 2021
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@guacamole guacamole merged commit dc6477d into master Jul 10, 2021
@guacamole guacamole deleted the missing-endpoints branch July 10, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants